Review Request: Add simple Type-and-Select feature to Folderview applet

Shantanu Tushar Jha jhahoneyk at gmail.com
Fri Jan 22 20:14:46 CET 2010



> On 2010-01-21 23:18:16, Fredrik Höglund wrote:
> > The code looks good, but I'm slightly concerned about the usability aspect in that this works
> > differently from type and search in Dolphin. There's also no visual feedback when the search
> > is reset.
> > 
> > I think it would be a good idea to get some input on this from our usability experts.

I think you're talking about the cycling which occurs on repeated presses of the same key.I did some experiments on Dolphin and found that if we have dirs 'pizza' 'pppinfo' 'press' then pressing 'ppp' selects 'press' (due to the cycling) instead of 'pppinfo'. This is quite ambiguous too because it depends on what the user meant. In my case, I meant it to be pppinfo.
But as you said, folderview shouldn't differ from dolphin, or we'll have inconsistency. So we can-
1. Make the folderview behave in the same way as Dolphin.
or,
2. See if someone has a better solution? (usability)

Will make changes according to further comments :)


- Shantanu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2659/#review3783
-----------------------------------------------------------


On 2010-01-22 19:13:29, Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2659/
> -----------------------------------------------------------
> 
> (Updated 2010-01-22 19:13:29)
> 
> 
> Review request for Plasma and Fredrik Höglund.
> 
> 
> Summary
> -------
> 
> This patch intends to provide a simple selection method to select icons. Its intended to be able to select a file plasma-desktop.desktop by just typing initial characters, "plas" for example.
> Comments on the hard-coded 2000ms welcome. If the user doesn't press any key within 2000ms after the last key press, the match string clears.
> 
> 
> This addresses bug 187241.
>     https://bugs.kde.org/show_bug.cgi?id=187241
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1078728 
>   trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1078728 
> 
> Diff: http://reviewboard.kde.org/r/2659/diff
> 
> 
> Testing
> -------
> 
> Works with the latest trunk.
> 
> 
> Thanks,
> 
> Shantanu
> 
>



More information about the Plasma-devel mailing list