Review Request: Sort Kickoff applications by name when "Show applications by name" config option is set.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2652/#review3763
-----------------------------------------------------------

Ship it!


nice catch! it looks good; please commit and backport to 4.4 (or one of us can backport it if you wish)

- Aaron


On 2010-01-20 08:11:53, Steven Eastland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2652/
> -----------------------------------------------------------
> 
> (Updated 2010-01-20 08:11:53)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> When applications are shown by name, currently they are still sorted by GenericName.  This patch fixes that and matches the behavior of the simple launcher applet.  Originally I had a patch that added a separate config option for "Sort applications by name" but that seemed excessive.  This also could be a potential fix for bug 188720.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/launcher.cpp 1073143 
> 
> Diff: http://reviewboard.kde.org/r/2652/diff
> 
> 
> Testing
> -------
> 
> Tested on my Arch Linux box with KDE SC 4.4 RC1 and works for me.
> 
> 
> Thanks,
> 
> Steven
> 
>