Review Request: Emit signal when launchQuery finish

Aaron Seigo aseigo at kde.org
Fri Jan 15 23:52:05 CET 2010



> On 2010-01-15 22:51:19, Aaron Seigo wrote:
> > small name change to the signal, otherwise looks good.

oops, forgot: it needs an @since to it (4.4 if it is going to be backported to the branch, which would have to happen prior t 4.4.0 being released if it is going to be backported, otherwise 4.5_


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2592/#review3718
-----------------------------------------------------------


On 2010-01-14 15:19:20, igorto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2592/
> -----------------------------------------------------------
> 
> (Updated 2010-01-14 15:19:20)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> Right now when we use RunnerManager::launchQuery we do not know when the query finish. Knowing it we can improve some animations. This patch add a new signal called launchQueryFinished.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/runnermanager.h 1074622 
>   trunk/KDE/kdelibs/plasma/runnermanager.cpp 1074622 
> 
> Diff: http://reviewboard.kde.org/r/2592/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> igorto
> 
>



More information about the Plasma-devel mailing list