Review Request: Additional style options for TaskManager e.g. "Icon only"

[Ralf Engels]

> On 2009-11-06 17:58:40, Aaron Seigo wrote:
> > the part to trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp doesn't apply to current trunk. i'm going to guess that it significantly complicates the drawing, however.
> > 
> > is the "collapse to just icons when there isn't enough room for at least 3 characters in addition to the icons and borders" feature not good enough? it addresses the issue you mention (vertical panels) without requiring any configuration at all.

Fixed the patch following your recommendations.
Just three characters is much to few. The right border will be blended out and you might get an arrow if you have too many icons reducing the space even more.

The patch now sets it to 3em which I think is the lower range of getting useful information out of the name.


- Ralf


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1342/#review2952
-----------------------------------------------------------


On 2010-02-25 15:53:26, Ralf Engels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1342/
> -----------------------------------------------------------
> 
> (Updated 2010-02-25 15:53:26)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The attached diff adds three style options to the task manager widget.
> 
> In addition to the "normal" icon-and-text style you can now have a icon-only, 
> text-only or text-under-icon style.
> 
> This means that e.g. the tasks are displayed by icon only (a much bigger icon 
> though).
> 
> The additional styles are especially useful if you have a vertical panel. In 
> the icon-and-text style I only had five characters of the task name left.
> 
> The new styles can be selected in the "Task Manager Settings". Default is the 
> Windows like icon-and-text.
> 
> Heyho...
> Don't anyone want to review this?
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp 1096015 
> 
> Diff: http://reviewboard.kde.org/r/1342/diff
> 
> 
> Testing
> -------
> 
> Tried all possible combinations of style options.
> 
> Note: Manual grouping does not seem but work, but I couldn't get this to work with the original either.
> 
> 
> Thanks,
> 
> Ralf
> 
>