Review Request: Updated Fifteen Puzzle plasmoid to use Plasma::Animator::SlideAnimation

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2939/#review4169
-----------------------------------------------------------

Ship it!


for now should go in, but the issue below needs investigating


trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp
<http://reviewboard.kde.org/r/2939/#comment3695>

    something that needs investigation: a paused animation actually stops the global animations timer? (provided there aren't other animations running)


- Marco


On 2010-02-15 12:47:31, Bruno Abinader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2939/
> -----------------------------------------------------------
> 
> (Updated 2010-02-15 12:47:31)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Replaced the deprecated animation API (Plasma::Animator::self()->moveItem()) with PlasmaAnimator::SlideAnimation on the Fifteen Puzzle plasmoid animation. The Piece class had a change on its inheritance chain: QGraphicsWidget replaces multiple inheritance from QObject, QGraphicsItem (but that could later be changed to a Plasma::Widget inheritance). A QHash was needed because there are times that multiple animations are run at the same time, thus not allowing us to have a single weak pointer, but a weak pointer for every Piece item in the board.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.h 1090523 
>   trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1090523 
>   trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.h 1090523 
>   trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp 1090523 
> 
> Diff: http://reviewboard.kde.org/r/2939/diff
> 
> 
> Testing
> -------
> 
> After compile + install, the Fifteen puzzle animations when switching pieces from the board behaved the same way.
> 
> 
> Thanks,
> 
> Bruno
> 
>