Review Request: search for pixel perfect versions of the svgs
Marco Martin
notmart at gmail.com
Mon Feb 15 23:09:09 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2960/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
this, when loading a Svg, searches for a version with a width-height- prefix to the element name, that is done slightly differently to be pixel-aligned at that size.
it will probably be necessary just for icon-ish stuff and a couple of little sizes, line 16x16 and 22x22
what has to be found out if having this fallback mechanism directly in Svg has a too big erformance hit, otherwise should be put just in the places that are useful, ike the battery or networkmanaer.
Diffs
-----
/trunk/KDE/kdelibs/plasma/svg.cpp 1090708
Diff: http://reviewboard.kde.org/r/2960/diff
Testing
-------
Screenshots
-----------
quality difference pretty evident
http://reviewboard.kde.org/r/2960/s/314/
Thanks,
Marco
More information about the Plasma-devel
mailing list