Review Request: Updated the ScrollWidget class to use the Plasma::Animator::create

Marco Martin notmart at gmail.com
Fri Feb 12 21:56:49 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2903/#review4139
-----------------------------------------------------------


it's public, so unfortunately you can't remove functions :/

- Marco


On 2010-02-12 20:43:29, loureiro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2903/
> -----------------------------------------------------------
> 
> (Updated 2010-02-12 20:43:29)
> 
> 
> Review request for Plasma, Marco Martin, igorto, Adenilson Cavalcanti, and Bruno Abinader.
> 
> 
> Summary
> -------
> 
> Now the ScrollWidgetPrivate class uses the Plasma::Animator::create(Plasma::Animator::SlideAnimation) on makeRectVisible method.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/widgets/scrollwidget.h 1089123 
>   trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1089123 
> 
> Diff: http://reviewboard.kde.org/r/2903/diff
> 
> 
> Testing
> -------
> 
> I've compile and run the plasma-netbook search and launcher to the scrollwiget works, looks fine to me.
> 
> 
> Thanks,
> 
> loureiro
> 
>



More information about the Plasma-devel mailing list