Review Request: Change the all Plasma::Animator::self to Plasma::Animator::create in FlashingLable class.

Marco Martin notmart at gmail.com
Wed Feb 10 22:18:36 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2877/#review4122
-----------------------------------------------------------

Ship it!


looks fine

- Marco


On 2010-02-10 21:13:10, loureiro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2877/
> -----------------------------------------------------------
> 
> (Updated 2010-02-10 21:13:10)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, igorto, Adenilson Cavalcanti, and Bruno Abinader.
> 
> 
> Summary
> -------
> 
> I've made the transition to the new Plasma::Animation API in FlashingLabel class.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/widgets/flashinglabel.h 1088307 
>   trunk/KDE/kdelibs/plasma/widgets/flashinglabel.cpp 1088307 
> 
> Diff: http://reviewboard.kde.org/r/2877/diff
> 
> 
> Testing
> -------
> 
> I've looking for the use of the FlashLabel class, that is used in MicroBlog. I've compile and the label animation works fine.
> 
> 
> Thanks,
> 
> loureiro
> 
>



More information about the Plasma-devel mailing list