Review Request: Fix crash in Weather plasma engine on resume from ram
Aurélien Gâteau
agateau at kde.org
Wed Feb 10 00:45:58 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2868/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
When resuming from ram, Weather engine crashes because it tries to free the forecast vector more than one time. The change here ensures one can run UKMETIon::reset() multiple times and one can call UKMETIon::reset() immediatly followed by UKMETIon::~UKMETIon().
This addresses bug 219036.
https://bugs.kde.org/show_bug.cgi?id=219036
Diffs
-----
trunk/KDE/kdebase/workspace/plasma/generic/dataengines/weather/ions/bbcukmet/ion_bbcukmet.h 1088007
trunk/KDE/kdebase/workspace/plasma/generic/dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp 1088007
Diff: http://reviewboard.kde.org/r/2868/diff
Testing
-------
Replaced ion_bbcukmet.so
Restarted plasma-desktop
Suspended computer to ram
Resumed, no crash
Thanks,
Aurélien
More information about the Plasma-devel
mailing list