Review Request: Plasma Netbook: Show the applet title bar when the applet has background or a hover event happens

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2861/#review4101
-----------------------------------------------------------

Ship it!


looks good, only remark m_hasBackground would be more clear as m_appletHasBackground, since i got it as it was true when the title has the own background the first time i readed it.

- Marco


On 2010-02-08 17:19:35, igorto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2861/
> -----------------------------------------------------------
> 
> (Updated 2010-02-08 17:19:35)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> Show the applet title bar when the applet has background or a hover event happens otherwise we have a ugly bar floating in newspaper
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/applettitlebar.h 1087075 
>   trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/applettitlebar.cpp 1087075 
> 
> Diff: http://reviewboard.kde.org/r/2861/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> igorto
> 
>