Review Request: Update KTorrent plasmoid animation to use QPropertyAnimation

Bruno Abinader brunoabinader at gmail.com
Mon Feb 8 15:17:19 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2859/
-----------------------------------------------------------

(Updated 2010-02-08 14:17:19.057929)


Review request for Plasma.


Changes
-------

Added a missing connect() to make the finished animation call animationFinished() slot + minor coding style fixes.


Summary
-------

Updated KTorrent plasmoid animation to use QPropertyAnimation instead of the deprecated Animator::self().


Diffs (updated)
-----

  trunk/extragear/network/ktorrent/plasma/applet/fadingitem.h 1087033 
  trunk/extragear/network/ktorrent/plasma/applet/fadingitem.cpp 1087033 

Diff: http://reviewboard.kde.org/r/2859/diff


Testing
-------

After compile + install, the ktorrent plasmoid behave the same way as before, without glitches or errors.


Thanks,

Bruno



More information about the Plasma-devel mailing list