Review Request: Removed reference to Plasma::Animator::self in nettoolbox class
Marco Martin
notmart at gmail.com
Thu Feb 4 20:20:59 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2830/#review4056
-----------------------------------------------------------
Ship it!
apart a tiny thing is good
trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/nettoolbox.cpp
<http://reviewboard.kde.org/r/2830/#comment3539>
you can use CamelCase here
- Marco
On 2010-02-04 19:07:28, loureiro wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2830/
> -----------------------------------------------------------
>
> (Updated 2010-02-04 19:07:28)
>
>
> Review request for Plasma, Marco Martin and igorto.
>
>
> Summary
> -------
>
> NetToolBox class now uses the new plasma API and use QPropertyAnimation to anime hoverEnter and hoverLeave events.
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/nettoolbox.h 1084313
> trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/nettoolbox.cpp 1084313
>
> Diff: http://reviewboard.kde.org/r/2830/diff
>
>
> Testing
> -------
>
> I've compile and run the plasma-netbook. All animations looks fine.
>
>
> Thanks,
>
> loureiro
>
>
More information about the Plasma-devel
mailing list