KDE/kdelibs/plasma/animations

[Aaron J. Seigo]

On February 2, 2010, Bruno Abinader wrote:
> Hi Aaron,
> 
> On Mon, Feb 1, 2010 at 2:18 PM, Aaron J. Seigo <aseigo at kde.org> wrote:
> > On February 1, 2010, Bruno de Oliveira Abinader wrote:
> >> SVN commit 1083641 by abinader:
> >> 
> >> Removed implicit enumerated animation movement direction combinations
> >> (i.e. MoveUpRight) and added support for combinations (i.e.
> >> MoveUp|MoveLeft). Currently used by RotationStacked and Slide
> >> animations, which were previously adapted to this clean design
> >> 
> >> 
> >>  M  +10 -15    animation.h
> >> 
> >> 
> >> --- trunk/KDE/kdelibs/plasma/animations/animation.h #1083640:1083641
> >> @@ -65,28 +65,23 @@
> >>       */
> >>      enum Reference {
> >>          Center = 0,
> >> -        Up,
> >> -        Down,
> >> -        Left,
> >> -        Right
> >> +        Up = 0x1,
> >> +        Down = 0x2,
> >> +        Left = 0x4,
> >> +        Right = 0x8
> >>      };
> >> 
> >>      /**
> >> -     * The movement direction of an animation.
> >> +     * Animation movement direction.
> >>       */
> >>      enum MovementDirection {
> >> -        MoveUp = 0,     /**< Move up */
> >> -        MoveUpRight,    /**< Move up and right */
> >> -        MoveRight,      /**< Move right */
> >> -        MoveDownRight,  /**< Move down and right */
> >> -        MoveDown,       /**< Move down */
> >> -        MoveDownLeft,   /**< Move down and left */
> >> -        MoveLeft,       /**< Move left */
> >> -        MoveUpLeft,     /**< Move up and left */
> >> -        MoveAny         /**< Move in any direction*/
> >> +        MoveAny = 0,
> >> +        MoveUp = 0x1,
> >> +        MoveRight = 0x2,
> >> +        MoveDown = 0x4,
> >> +        MoveLeft = 0x8
> >>      };
> > 
> > these should have Q_DECLARE_FLAGS entries and this must be backported to
> > the 4.4 branches before 4.4.0 comes out at this is essentially an API
> > change. code compiled against 4.4 will have the wrong values for these
> > enumerations and so will behave oddly if run against a 4.5 kdelibs.
> 
> Sure thing. I've updated the MovementDirection and Reference enums to
> use QFlags (with Q_DECLARE_FLAGS - see
> http://websvn.kde.org/?view=revision&revision=1084090) and now I'm
> going to backport these changes to 4.4.

awesome; thanks :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks