Review Request: Prevent plasma tooltips to draw halos on empty lines.

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6233/#review9467
-----------------------------------------------------------

Ship it!


good catch and simple solution ;)

- Marco


On 2010-12-29 17:55:36, Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6233/
> -----------------------------------------------------------
> 
> (Updated 2010-12-29 17:55:36)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> In a multi-line Plasma tooltip, don't draw a halo around empty lines.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/private/tooltip.cpp 1210128 
> 
> Diff: http://svn.reviewboard.kde.org/r/6233/diff
> 
> 
> Testing
> -------
> 
> Test done with r1210128, results are shown in the screenshots below.
> 
> 
> Screenshots
> -----------
> 
> Calendar Tooltip
>   http://svn.reviewboard.kde.org/r/6233/s/596/
> Calendar Tooltip patched
>   http://svn.reviewboard.kde.org/r/6233/s/597/
> Clock Tooltip
>   http://svn.reviewboard.kde.org/r/6233/s/598/
> Clock Tooltip patched
>   http://svn.reviewboard.kde.org/r/6233/s/599/
> 
> 
> Thanks,
> 
> Diego
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101229/2ae9664b/attachment.htm