Review Request: Fix crash in plasmapkg

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6184/#review9371
-----------------------------------------------------------

Ship it!


- Aaron


On 2010-12-22 13:35:33, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6184/
> -----------------------------------------------------------
> 
> (Updated 2010-12-22 13:35:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> when using plasmapkg -t theme -u /home/neoclust/.kde4/share/apps/desktoptheme/G-Remix/metadata.desktop  ( which is a wrong use of the tool i agree )  plasmapkg crash.
> 
> this is because archive is set to 0 and not checked before if (archive->open(QIODevice::ReadOnly)) {
> 
> this patch fixes this crash
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/packagestructure.cpp 1208544 
> 
> Diff: http://svn.reviewboard.kde.org/r/6184/diff
> 
> 
> Testing
> -------
> 
> plasmapkg -t theme -u ${the file you want}
> 
> 
> Thanks,
> 
> Nicolas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101222/1b436a2f/attachment.htm