Review Request: The clock applet chiming per hour, half-hour and quarter hour

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6108/#review9213
-----------------------------------------------------------


could be a good idea (even if i'm not sure this should be in the default clock, maybe could be worth its own)
if it's going in it should wait svn reopens for 4.7 development, or go into git when the migrtion is done.
right now there are a couple of (easy to fix) issues:


/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h
<http://svn.reviewboard.kde.org/r/6108/#comment10084>

    m_ prefix



/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp
<http://svn.reviewboard.kde.org/r/6108/#comment10086>

    objects shouldn't be created in paintinterface, would impact fluidity and pile up without being deleted (only at applet destruction) only a global object should exist.



/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp
<http://svn.reviewboard.kde.org/r/6108/#comment10085>

    this debug output should become more sober in the final version ;)


- Marco


On 2010-12-12 19:20:12, Sunny Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6108/
> -----------------------------------------------------------
> 
> (Updated 2010-12-12 19:20:12)
> 
> 
> Review request for Plasma, Aaron Seigo and Anne-Marie Mahfouf.
> 
> 
> Summary
> -------
> 
> Hello Everybody,
> 
> i have implemented the chiming of the analog clock every hour.though i have hard coded it and it would only chime every hour. and not for 45 mins. Presently I am working on the development of a ui which would allow the user to set the clock to chime according to the choice of the user. 
> 
> thanks,
> sunny_slls
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=232004.
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=232004
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt 1203585 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h 1203585 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp 1203585 
> 
> Diff: http://svn.reviewboard.kde.org/r/6108/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sunny
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101212/922ca340/attachment-0001.htm