Review Request: Contact runner works correctly in more cases

Aaron Seigo aseigo at kde.org
Sat Dec 11 21:55:55 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6089/#review9203
-----------------------------------------------------------

Ship it!


- Aaron


On 2010-12-11 12:54:08, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6089/
> -----------------------------------------------------------
> 
> (Updated 2010-12-11 12:54:08)
> 
> 
> Review request for Plasma, Aaron Seigo and Teemu Rytilahti.
> 
> 
> Summary
> -------
> 
> Works around BUG:249157 by using the form "NAME <EMAIL>" instead of "NAME<EMAIL>".
> The first version is perfectly valid, the second that does not always work [1] might also be valid.
> 
> [1] Fails e.g. for NAME="a ü-a" or "ü-a"
> 
> CCBUG:249157
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/runners/contacts/contactsrunner.cpp 1205477 
> 
> Diff: http://svn.reviewboard.kde.org/r/6089/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101211/bad16a87/attachment.htm 


More information about the Plasma-devel mailing list