Review Request: Lockout widget: Explain to the user that he must select a button to show

Nicolas Lécureuil neoclust.kde at free.fr
Sun Dec 5 22:41:56 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6041/
-----------------------------------------------------------

(Updated 2010-12-05 21:41:56.363884)


Review request for Plasma.


Changes
-------

I updated the patch this way : 
- I changed the string.
- I fixed the UI so when it is opened , the widget is disabled if only one checkbox is checked.


Summary
-------

When the user ask to show no buttons in the lockout widget, nothing tell the user that this is not possible, and when he saves the configuration nothing changed in the widget.

With this patch, if the user unselect all the checkboxes, he is warned.


This addresses bug 256879.
    https://bugs.kde.org/show_bug.cgi?id=256879


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.h 1203948 
  trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp 1203948 

Diff: http://svn.reviewboard.kde.org/r/6041/diff


Testing
-------


Thanks,

Nicolas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101205/7481265b/attachment-0001.htm 


More information about the Plasma-devel mailing list