Review Request: Allows umlauts and other non-ASCII symbols in the locations runner for URLs

[Matthias Fuchs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6042/
-----------------------------------------------------------

Review request for Plasma and Aaron Seigo.


Summary
-------

Allows a wider range of urls without a protocol to be accepted, like those containing umlauts etc., queries, or IPV4-Adresses.
If no protocol has be defined, then ports aren't supported.
BUG:227380


This addresses bug 227380.
    https://bugs.kde.org/show_bug.cgi?id=227380


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationrunner.cpp 1203489 

Diff: http://svn.reviewboard.kde.org/r/6042/diff


Testing
-------

Tried with different urls, including the one of the bug report www.hörstreich.de, google.at, 74.125.39.99/search?hl=en&biw=1280&bih=891&q=kde&aq=f&aqi=g10&aql=&oq=&gs_rfai= etc.

There is one problem though that is unrelated to this patch and did _not_ exist in KDE 4.5.4
If I enter "google.at" it will display the result that I can go to http://google.at, yet if I add ":\d" e.g. google.at:8 the result won't be updated as nothing matches, yet the old result still stays.
In KDE 4.5.4 the old result would also disappear after a short time.


Thanks,

Matthias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101204/9b45d878/attachment.htm