Review Request: Lockout widget: Explain to the user that he must select a button to show

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6041/#review9121
-----------------------------------------------------------


unfortunately, a modal dialog like KMessageBox can't be used since it will block the rest of the UI.

instead, it would probably be better if there was a text in the dialog itself (so the user knows ahead of time what they must do) and simply prevent the last item from becoming unchecked (so if the # of selected buttons == 1, don't let it become unselected).

note that we are also in string freeze, so this probably needs to wait for 4.7.


trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp
<http://svn.reviewboard.kde.org/r/6041/#comment9951>

    method start with lower case letters; probably just buttonsChanged() in this case



trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp
<http://svn.reviewboard.kde.org/r/6041/#comment9950>

    no spaces within ()s.



trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp
<http://svn.reviewboard.kde.org/r/6041/#comment9949>

    this will block the UI, which can't happen in plasma-desktop.


- Aaron


On 2010-12-04 01:58:14, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6041/
> -----------------------------------------------------------
> 
> (Updated 2010-12-04 01:58:14)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> When the user ask to show no buttons in the lockout widget, nothing tell the user that this is not possible, and when he saves the configuration nothing changed in the widget.
> 
> With this patch, if the user unselect all the checkboxes, he is warned.
> 
> 
> This addresses bug 256879.
>     https://bugs.kde.org/show_bug.cgi?id=256879
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.h 1202613 
>   trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp 1202613 
> 
> Diff: http://svn.reviewboard.kde.org/r/6041/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101204/c104f5f2/attachment.htm