kdreview: dictionary runner; changes needed to Plasma::RunnerManager?

[Jason A. Donenfeld]

On Sat, Aug 28, 2010 at 17:10, Aaron J. Seigo <aseigo at kde.org> wrote:
>
> well, we can fix that. if nothing else, this was a great exercise in
> discovering what needs to be improved exactly, and how :)
>
> match is given the RunnerContext on each invocation. that RunnerContext may
> become invalid at any time, though, so there is no "current" or "the"
> RunnerContext in this sense.
>
> a runner could create a separate QObject subclass for each call that holds
> onto the RunnerContext passed it as a member variable, and that object
> could
> do exactly as you describe (and then delete itself when finished).



I'm going to re-factor the dictionary runner to use this approach so that
the new setReentrant(true) switch will have something to test against, for
whoever ends up implementing that.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100829/b6ffaab6/attachment.htm