Review Request: Launcher support for libtaskmanager
Anton Kreuzkamp
akreuzkamp at web.de
Wed Aug 25 19:59:38 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4585/
-----------------------------------------------------------
(Updated 2010-08-25 17:59:38.336993)
Review request for Plasma.
Changes
-------
Changes as suggested by Aaron.
Summary
-------
Adds support for Windows 7 like launchers in libtaskmanager.
(I'm on holliday from 12th July until 1st August so I will not be able to reply during this time.)
Diffs (updated)
-----
/trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt 1148442
/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 1148442
/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.cpp 1148442
/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.h 1148442
/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.cpp 1148442
/trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp 1148442
/trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1148442
/trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1148442
/trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h PRE-CREATION
/trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp PRE-CREATION
/trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp 1148442
/trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/kustodiangroupingstrategy.cpp 1148442
/trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/manualgroupingstrategy.cpp 1148442
/trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp 1148442
/trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 1148442
/trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1166310
/trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1166310
/trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1166310
/trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.cpp 1148442
Diff: http://reviewboard.kde.org/r/4585/diff
Testing (updated)
-------
Tested with a small test-applett and everything works.
Edit: In "GroupManagerPrivate::removeTask(TaskPtr task)" the method "task->classClass()"(l.326) returns an empty string (in "GroupManagerPrivate::addTask(TaskPtr task)" the method "item->task()->classClass()"(l.289) works just fine), so Launchers don't get showed again after quitting the application.
Thanks,
Anton
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100825/205ac7a8/attachment-0001.htm
More information about the Plasma-devel
mailing list