Review Request: Game of Life Plasmoid -- Cleanup and reflection/density feature addition

[the.goofeedude at gmail.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5027/
-----------------------------------------------------------

(Updated 2010-08-23 19:12:21.184543)


Review request for Plasma.


Changes
-------

The updated diff is built on top of the bugfix which was submitted as 1166819 in trunk (http://reviewboard.kde.org/r/5055/)

Also included in the updated diff are member variable renamings (prepending m_ to member variable names.)


Summary (updated)
-------

Update (8/23/10): The patch adds two new features to the life applet: game board reflection (the user can choose to generate initial populations that are symmetrical about the horizontal and/or vertical axes,) and user-configurable population density (the user can choose what approximate percentage of cells will be alive in the initial population.)

With the addition of the new configuration options, the configuration UI was also updated so that using tab to scroll through options would be consistent (top to bottom.)

This submit also includes member variable renamings (prepending m_ to member variable names.)


Diffs (updated)
-----

  /trunk/KDE/kdeplasma-addons/applets/life/life.h 1166777 
  /trunk/KDE/kdeplasma-addons/applets/life/life.cpp 1167084 
  /trunk/KDE/kdeplasma-addons/applets/life/lifeConfig.ui 1166777 

Diff: http://reviewboard.kde.org/r/5027/diff


Testing
-------

Various game board sizes were tested (odd and even heights and widths, square and non-square.) The configuration dialog was opened several times and tested to confirm tab order.

Various population densities were tested, including 0% (confirmed no cells were alive) and 100% (confirmed that all cells were alive.)

All combinations of vertical/horizontal/no reflection were tested at odd and even heights and widths, square and non-square.

Tests consisted of setting the proper configuration options, then watching the board for a few generations and confirming that no crashes occurred and that all cells appeared to live and die properly. 


Screenshots
-----------

Updated Configuration Dialog
  http://reviewboard.kde.org/r/5027/s/481/
Board Using Vertical and Horizontal Reflection
  http://reviewboard.kde.org/r/5027/s/482/


Thanks,

obby

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100823/a20a28ca/attachment.htm