Review Request: Add "Show Icon only" option to the tasks applet

Marco Martin notmart at gmail.com
Mon Aug 23 11:00:46 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5078/#review7162
-----------------------------------------------------------


this very patch appeared here for several times already.
and as usual, the question is: what real value gives over auto hiding the text when there is not enough space?

- Marco


On 2010-08-22 13:52:33, Björn Ruberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5078/
> -----------------------------------------------------------
> 
> (Updated 2010-08-22 13:52:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds the option to put the taskbar in an icon-only mode - similar as in Windows 7 . This is an much requested feature in bugzilla.
> It is fairly simple and just using features already existing in the code, adding an m_showIconOnly member to the layout and the abstractitem plus the adaption of the config ui.
> 
> 
> This addresses bug 159480.
>     https://bugs.kde.org/show_bug.cgi?id=159480
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.ui 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.h 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.h 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 1166313 
> 
> Diff: http://reviewboard.kde.org/r/5078/diff
> 
> 
> Testing
> -------
> 
> Moved panel around and made sure it works. Looks actually pretty good this icon-only mode!
> 
> 
> Thanks,
> 
> Björn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100823/a9a21eda/attachment.htm 


More information about the Plasma-devel mailing list