Review Request: Enabling "ShowDashboard" widget to show Dashboard while anything is dragged and hovered over it.
Aaron Seigo
aseigo at kde.org
Thu Aug 19 18:59:35 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5063/#review7140
-----------------------------------------------------------
Ship it!
one small comment about the timeout #, but this patch can go in.. cheers and thanks for the patch :)
trunk/KDE/kdeplasma-addons/applets/showdashboard/showdashboard.cpp
<http://reviewboard.kde.org/r/5063/#comment7277>
testing with this, i found 750ms "more natural feeling": it didn't trigger accidentally as easily and it didn't feel like it took very long to trigger it either.
- Aaron
On 2010-08-19 16:09:42, Sinny Kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5063/
> -----------------------------------------------------------
>
> (Updated 2010-08-19 16:09:42)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Added feature to drag anything and adding it directly to the DashBoard.
> It can be done by dragging anything like file/widget and hovering it over "ShowDashBoard" widget .
>
>
> Diffs
> -----
>
> trunk/KDE/kdeplasma-addons/applets/showdashboard/showdashboard.h 1164952
> trunk/KDE/kdeplasma-addons/applets/showdashboard/showdashboard.cpp 1164952
>
> Diff: http://reviewboard.kde.org/r/5063/diff
>
>
> Testing
> -------
>
> Tested it on trunk.It's working absolutely fine and i really enjoyed it while doing :)
>
>
> Thanks,
>
> Sinny
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100819/7f4548bb/attachment.htm
More information about the Plasma-devel
mailing list