Review Request: Enabling "ShowDashboard" widget to show Dashboard while anything is dragged and hovered over it.
Aaron Seigo
aseigo at kde.org
Wed Aug 18 19:13:30 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5063/#review7134
-----------------------------------------------------------
trunk/KDE/kdeplasma-addons/applets/showdashboard/showdashboard.cpp
<http://reviewboard.kde.org/r/5063/#comment7274>
my only concern with this (and now that i think about it, the other patch as well) is that this will trigger _instantly_ on drag enter which means you can no longer drag across this widget without triggering it.
that means that this will become a "no dragging" zone that the user will have to avoid while dragging things elsewhere.
this is easily fixed though:
have a QTimer connected to toggleShowDashboard() that is started in dragEnterEvent with a small timeout (e.g. 300ms) and which is stopped in dragLeaveEvent. that way, if the mouse stays in the widget for at least that amount of time with a drag, it triggers. but if it enters and leaves quickly (just being passed through) then nothing happens.
- Aaron
On 2010-08-18 15:15:58, Sinny Kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5063/
> -----------------------------------------------------------
>
> (Updated 2010-08-18 15:15:58)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Added feature to drag anything and adding it directly to the DashBoard.
> It can be done by dragging anything like file/widget and hovering it over "ShowDashBoard" widget .
>
>
> Diffs
> -----
>
> trunk/KDE/kdeplasma-addons/applets/showdashboard/showdashboard.h 1164952
> trunk/KDE/kdeplasma-addons/applets/showdashboard/showdashboard.cpp 1164952
>
> Diff: http://reviewboard.kde.org/r/5063/diff
>
>
> Testing
> -------
>
> Tested it on trunk.It's working absolutely fine and i really enjoyed it while doing :)
>
>
> Thanks,
>
> Sinny
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100818/fa469202/attachment.htm
More information about the Plasma-devel
mailing list