Review Request: Game of Life Applet - fix to off-by-one in array traversal

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5055/#review7094
-----------------------------------------------------------

Ship it!


go for it :)


/trunk/KDE/kdeplasma-addons/applets/life/life.cpp
<http://reviewboard.kde.org/r/5055/#comment7223>

    watch the trailing spaces


- Marco


On 2010-08-16 18:18:18, obby wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5055/
> -----------------------------------------------------------
> 
> (Updated 2010-08-16 18:18:18)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> This patch fixes a off-by-one error which would lead to the last cell of the array never coming alive.
> 
> Also, parentheses were added to disambiguate some arithmetic expression and enforce operator precedence.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/life/life.cpp 1163310 
> 
> Diff: http://reviewboard.kde.org/r/5055/diff
> 
> 
> Testing
> -------
> 
> Started applet, determined that the state of last cell in the array (bottommost rightmost cell) was calculated properly, and came alive when appropriate.
> 
> 
> Thanks,
> 
> obby
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100816/9c4f164b/attachment.htm