Review Request: permit the simple wallpaper name in the config file

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4947/#review6981
-----------------------------------------------------------

Ship it!


some small comments below, but i think this can go in.


/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp
<http://reviewboard.kde.org/r/4947/#comment7010>

    to avoid the case where the file really just doesn't exist, i wonder if the test should be something like:
    
    if (QDir::isAbsolutePath(m_wallpaper)) {
        // use m_wallpaper with Package directly
    } else {
       // use KStandardDirs to locate a package
    }
    
    that would prevent checking disk with QFile::exists as well prevent absolute paths which no longer exist falling back to the "find a package" path?



/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp
<http://reviewboard.kde.org/r/4947/#comment7011>

    spaces around '+'


- Aaron


On 2010-08-10 18:45:50, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4947/
> -----------------------------------------------------------
> 
> (Updated 2010-08-10 18:45:50)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch makes possible to specify in the config file just the wallpaper name, such as "Ethias" or "Grass"
> this would be necessary to do default plasma layouts with a different wallpaper per containment for instance.
> the patch looks like a quick and dirty way to me, another could be a Package constructor that takesthe desktop file, or the associated KService as a path..
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1157559 
> 
> Diff: http://reviewboard.kde.org/r/4947/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100810/cbb51c02/attachment-0001.htm