Review Request: permit the simple wallpaper name in the config file

Marco Martin notmart at gmail.com
Tue Aug 10 13:10:10 CEST 2010



> On 2010-08-09 17:48:58, Aaron Seigo wrote:
> > another thought that occurs to me: i wonder if the "translate a package name to an absolute path" doesn't belong in the Desktop Scripting .. that way all wallpapers would get the benefit of it and it would be a penalty paid just once (at initial layout loading).

probably...
fact is however my main use case was for plasma mobile, that doesn't have desktop scripting :/
so probablyboth are needed, this kind of resolution in image, and a convenience function is desktop scripting as well

and what about a static Package *Package::fromName(Qstring)?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4947/#review6916
-----------------------------------------------------------


On 2010-08-09 15:48:31, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4947/
> -----------------------------------------------------------
> 
> (Updated 2010-08-09 15:48:31)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch makes possible to specify in the config file just the wallpaper name, such as "Ethias" or "Grass"
> this would be necessary to do default plasma layouts with a different wallpaper per containment for instance.
> the patch looks like a quick and dirty way to me, another could be a Package constructor that takesthe desktop file, or the associated KService as a path..
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1157559 
> 
> Diff: http://reviewboard.kde.org/r/4947/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100810/13e7978c/attachment.htm 


More information about the Plasma-devel mailing list