Review Request: Enable the boundingRect to grow along with the board on the fifteenPuzzle plasmoid.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4869/#review6770
-----------------------------------------------------------

Ship it!


there's one small improvement to be made (see comment below), and this can go in as the fix is correct.

(do you have an svn account?)


/trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp
<http://reviewboard.kde.org/r/4869/#comment6581>

    this is, in fact, what the default implementation of QGraphicsItem::boundingRect() does. so this method can be completely removed.


- Aaron


On 2010-08-03 15:48:24, Alex Raymond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4869/
> -----------------------------------------------------------
> 
> (Updated 2010-08-03 15:48:24)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> When the plasmoid was resized (enlarged), the boundingRect for the pieces remained at the same size, which made the pieces clickable only at the top-left corner (within the size of the original piece). This patch corrects it.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1158348 
>   /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/piece.h 1158348 
>   /trunk/KDE//kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp 1158348 
> 
> Diff: http://reviewboard.kde.org/r/4869/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100803/f11258d0/attachment.htm