Review Request: battery: change brightness on mouse wheel

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4810/#review6758
-----------------------------------------------------------


you don't need to propagate wheel events (or most other events, for that matter, unless there is an underlying implementation that also needs to be called). i don't know why it would be crashing with looking at the backtrace.

that said, however, i don't see the connection between the battery icon and the brightness of the screen. screen brightness affects power usage, sure, but it's a little like scrolling on the app menu and having it switch between windows :)

as such, i don't think this is something that should go into svn.

- Aaron


On 2010-08-01 01:01:33, Rafa? Mi?ecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4810/
> -----------------------------------------------------------
> 
> (Updated 2010-08-01 01:01:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This implements feature requested in bug 230888 . Scrolling over battery plasmoid changes brightness.
> 
> In (uncommon) case of multiple brightness devices it affects the first registered device. We may want to make it configurable in the future.
> 
> 
> This addresses bug 230888.
>     https://bugs.kde.org/show_bug.cgi?id=230888
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h 1157714 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp 1157714 
> 
> Diff: http://reviewboard.kde.org/r/4810/diff
> 
> 
> Testing
> -------
> 
> It works fine for my notebook, doesn't crash on machine without brightness device.
> 
> The part I am not sure about is:
> Applet::wheelEvent(e);
> I though we need to propagate events so tried to use this call. However using it causes crash. Help?
> 
> 
> Thanks,
> 
> Rafa?
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100801/46de7d6e/attachment-0001.htm