Review Request: desktop scripting: access template informations

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3852/#review5336
-----------------------------------------------------------


one small comment, but nothing pressing. the global variables are fine in this case imho. the scripting is designed for one-off, short-lived scripts so it's ok to err on the side of script convenience over runtime cleanliness. please document this addition on http://techbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting after committing. thanks.


/trunk/KDE/kdebase/workspace/libs/plasmagenericshell/scripting/scriptengine.cpp
<http://reviewboard.kde.org/r/3852/#comment5023>

    instead of offers.first(), i'd use the info object instead.


- Aaron


On 2010-04-30 13:01:59, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3852/
> -----------------------------------------------------------
> 
> (Updated 2010-04-30 13:01:59)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this makes accessible the template name and comment from the script contained in the template itself.
> I would use it to give translated activity names in the netbook shell.
> i'm not sure registering global variables in this way is the best way to go.
> progably a class with those properties should be binded instead?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/scripting/scriptengine.cpp 1121104 
> 
> Diff: http://reviewboard.kde.org/r/3852/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>