Review Request: SkipSwitcher functionality

[Martin Gräßlin]

> On 2010-04-26 09:50:44, Lubos Lunak wrote:
> > What was the rationale for the _STATE_SKIP_SWITCHER window flag itself again? I see no problem with having this as a user preference, but such flags used by applications are generally just hacks instead of proper solutions (such as window types). I think this was discussed at Tokamak, but I don't remember the usercase or rationale for this.

ok, that would be an option, too. In that case Plasma devs should give us a list of window types and the desired functionality and we check in Client::wantsTabFocus() for the type. We could keep the window rule for skip switcher nevertheless without setting the window state. Hmm that doesn't sound that bad.

Aaron, Marco what do you think? We need window types nevertheless for e.g. recognizing dashboard.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3800/#review5240
-----------------------------------------------------------


On 2010-04-24 10:16:21, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3800/
> -----------------------------------------------------------
> 
> (Updated 2010-04-24 10:16:21)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, and Lubos Lunak.
> 
> 
> Summary
> -------
> 
> This patch adds _KDE_STATE_SKIP_SWITCHER to _NET_WM_STATE. Alt+Tab will exclude windows with this state set (this automatically includes the alt+tab replacement effects). I will extend Present Windows and Desktop Grid to honour this flag, too.
> 
> As soon as the patch is committed I will bring this to the NETWM mailinglist to standardise the flag, so that it becomes _NET_WM_STATE_SKIP_SWITCHER.
> 
> This can be used by plasma to exclude windows from alt+tab. Therefore KWindowSystem::setState( winId, Net::SkipSwitcher ) can be used.
> 
> 
> This addresses bugs 171192 and 179723.
>     https://bugs.kde.org/show_bug.cgi?id=171192
>     https://bugs.kde.org/show_bug.cgi?id=179723
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/kwin/client.h 1117299 
>   trunk/KDE/kdebase/workspace/kwin/client.cpp 1117299 
>   trunk/KDE/kdebase/workspace/kwin/events.cpp 1117299 
>   trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidget.h 1117299 
>   trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidget.cpp 1117299 
>   trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidgetbase.ui 1117299 
>   trunk/KDE/kdebase/workspace/kwin/manage.cpp 1117299 
>   trunk/KDE/kdebase/workspace/kwin/rules.h 1117299 
>   trunk/KDE/kdebase/workspace/kwin/rules.cpp 1117299 
>   trunk/KDE/kdebase/workspace/kwin/sm.h 1117299 
>   trunk/KDE/kdebase/workspace/kwin/sm.cpp 1117299 
>   trunk/KDE/kdebase/workspace/kwin/tabbox.cpp 1117299 
>   trunk/KDE/kdebase/workspace/kwin/workspace.cpp 1117299 
>   trunk/KDE/kdelibs/kdeui/windowmanagement/kwindowsystem.h 1117299 
>   trunk/KDE/kdelibs/kdeui/windowmanagement/netwm.cpp 1117299 
>   trunk/KDE/kdelibs/kdeui/windowmanagement/netwm_def.h 1117299 
> 
> Diff: http://reviewboard.kde.org/r/3800/diff
> 
> 
> Testing
> -------
> 
> Adding a window specific rule updates the state and the window is not shown in tabbox.
> 
> 
> Thanks,
> 
> Martin
> 
>