Review Request: Close notification with middle click

[Marco Martin]

> On 2010-04-24 19:20:39, Marco Martin wrote:
> > i'm not sure it should really close it.
> > it should just hide the automatic popup window i think
> > (as it does already with left click after a second the mouse cursor hovered the notification)

I mean: in NotificationStack::mouseReleaseEvent()
if the pressed button is left, check the timer as is now, if the button is middle, always emit hideRequested()

thinking about it, there could be an use case also for actually deleting the notification...

what do you think?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3802/#review5208
-----------------------------------------------------------


On 2010-04-24 19:17:46, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3802/
> -----------------------------------------------------------
> 
> (Updated 2010-04-24 19:17:46)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> Adding functionality to close a notifcation when clicking anywhere on the notification with a middle click. This makes it easier to close the notification as you do not have to hit the tiny close button.
> 
> I was asked by a user to add this feature :-)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.h 1117624 
>   trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp 1117624 
> 
> Diff: http://reviewboard.kde.org/r/3802/diff
> 
> 
> Testing
> -------
> 
> Tested with knotify passivepopup: middle clicking on the notification closes it both as a standalone notification and in the notification browser.
> 
> 
> Thanks,
> 
> Martin
> 
>