Review Request: SkipSwitcher functionality

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3800/
-----------------------------------------------------------

Review request for Plasma, Aaron Seigo, Marco Martin, and Lubos Lunak.


Summary
-------

This patch adds _KDE_STATE_SKIP_SWITCHER to _NET_WM_STATE. Alt+Tab will exclude windows with this state set (this automatically includes the alt+tab replacement effects). I will extend Present Windows and Desktop Grid to honour this flag, too.

As soon as the patch is committed I will bring this to the NETWM mailinglist to standardise the flag, so that it becomes _NET_WM_STATE_SKIP_SWITCHER.

This can be used by plasma to exclude windows from alt+tab. Therefore KWindowSystem::setState( winId, Net::SkipSwitcher ) can be used.


This addresses bugs 171192 and 179723.
    https://bugs.kde.org/show_bug.cgi?id=171192
    https://bugs.kde.org/show_bug.cgi?id=179723


Diffs
-----

  trunk/KDE/kdebase/workspace/kwin/client.h 1117299 
  trunk/KDE/kdebase/workspace/kwin/client.cpp 1117299 
  trunk/KDE/kdebase/workspace/kwin/events.cpp 1117299 
  trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidget.h 1117299 
  trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidget.cpp 1117299 
  trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwinrules/ruleswidgetbase.ui 1117299 
  trunk/KDE/kdebase/workspace/kwin/manage.cpp 1117299 
  trunk/KDE/kdebase/workspace/kwin/rules.h 1117299 
  trunk/KDE/kdebase/workspace/kwin/rules.cpp 1117299 
  trunk/KDE/kdebase/workspace/kwin/sm.h 1117299 
  trunk/KDE/kdebase/workspace/kwin/sm.cpp 1117299 
  trunk/KDE/kdebase/workspace/kwin/tabbox.cpp 1117299 
  trunk/KDE/kdebase/workspace/kwin/workspace.cpp 1117299 
  trunk/KDE/kdelibs/kdeui/windowmanagement/kwindowsystem.h 1117299 
  trunk/KDE/kdelibs/kdeui/windowmanagement/netwm.cpp 1117299 
  trunk/KDE/kdelibs/kdeui/windowmanagement/netwm_def.h 1117299 

Diff: http://reviewboard.kde.org/r/3800/diff


Testing
-------

Adding a window specific rule updates the state and the window is not shown in tabbox.


Thanks,

Martin