Review Request: Added Plasma::PendulumCurve class

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3513/#review5171
-----------------------------------------------------------


almost there!
i'm reluctant with that isSwing however


trunk/KDE/kdelibs/plasma/animations/rotation.cpp
<http://reviewboard.kde.org/r/3513/#comment4666>

    i think this shouldn't be here



trunk/KDE/kdelibs/plasma/animations/rotation.cpp
<http://reviewboard.kde.org/r/3513/#comment4667>

    again, the pendulumcurve should be set to the rotation, but no extra api in the rotation itself, and it should always set the one you give, not depending from that isswing


- Marco


On 2010-04-22 16:15:22, Bruno Abinader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3513/
> -----------------------------------------------------------
> 
> (Updated 2010-04-22 16:15:22)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, igorto, and Adenilson Cavalcanti.
> 
> 
> Summary
> -------
> 
> The Plasma::PendulumCurve class subclasses from Qt's QEasingCurve and implements a static function which simulates a "pendulum" effect by varying the progress value from 0 to 1, 1 to 0, 0 to -1 and -1 to 0 in a linear way. Together with this easing curve, some modifications were made on the Plasma::RotationAnimation to support a property called "isSwing" which enables the "swing" mode on the target widget, with its angle decrementing through each loop count.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/CMakeLists.txt 1117560 
>   trunk/KDE/kdelibs/plasma/animations/animation.h 1117560 
>   trunk/KDE/kdelibs/plasma/animations/pendulumcurve.h PRE-CREATION 
>   trunk/KDE/kdelibs/plasma/animations/pendulumcurve.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/plasma/animations/rotation.cpp 1117560 
>   trunk/KDE/kdelibs/plasma/animations/rotation_p.h 1117560 
> 
> Diff: http://reviewboard.kde.org/r/3513/diff
> 
> 
> Testing
> -------
> 
> An example code was added to the "plasma applet animation example" (in kdeexamples/plasma/c++/plasmoid/animation). That code will be later commited, after this request gets successfully merged. You can grab the example code here: http://pastebin.com/07ntUsBM
> 
> 
> Thanks,
> 
> Bruno
> 
>