Activity Feedback

Richard Moore rich at kde.org
Wed Apr 14 00:10:23 CEST 2010


Hi Ivan,

Some feedback on what's in kde-review:

- Looks pretty good, yay!

- Some of the param names specified in the doxygen magic don't match
the argument names, eg. ID when the param is called wid. This will
lead to doc warnings etc.

- No use of Q_PROPERTY etc. This one is the only substantive issue I
see. I think we should be defining the relevent property magic in
these classes before they get moved from review.

Other than that, nothing so far, but I'll keep looking. Looking good :-)

Cheers

Rich.


More information about the Plasma-devel mailing list