Review Request: Add libqalculate support to calculator runner

[Alessandro Diaferia]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3483/#review4973
-----------------------------------------------------------


I didn't try the patch locally but the code seems good to me and really well done except for what follows...


/trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.cpp
<http://reviewboard.kde.org/r/3483/#comment4417>

    I know nothing about libqalculate but doesn't this lead to a mem leak?



/trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.cpp
<http://reviewboard.kde.org/r/3483/#comment4416>

    wouldn't it be safer using QDir::homePath()? Or, better, does Qalculate have an access method for that directory?


- Alessandro


On 2010-04-03 11:03:20, Matteo Agostinelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3483/
> -----------------------------------------------------------
> 
> (Updated 2010-04-03 11:03:20)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> Adds libqalculate to the default calculator runner. This enables advanced features such as unit/currency conversion, equation solving, symbolic manipulation and more.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/cmake/modules/FindQalculate.cmake PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/CMakeLists.txt 1109927 
>   /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/calculatorrunner.h 1109927 
>   /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/calculatorrunner.cpp 1109927 
>   /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.h PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/3483/diff
> 
> 
> Testing
> -------
> 
> Tested for several weeks without crashes
> 
> 
> Thanks,
> 
> Matteo
> 
>