Review Request: Change behaviour of 'Next Wallpaper Image' menu

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3529/#review4939
-----------------------------------------------------------



trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp
<http://reviewboard.kde.org/r/3529/#comment4398>

    this looks sensible, however is there any reason that this couldn't be put directly into nextSlide? would make the patch simpler and avoid similar problems in future. 


- Aaron


On 2010-04-09 06:53:02, Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3529/
> -----------------------------------------------------------
> 
> (Updated 2010-04-09 06:53:02)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch change the behaviour of displaying wallpaper in slideshow mode.
> In old behaviour it's possible the next slide selected from 'Next Wallpaper Image' menu from context menu,
> will not be displayed in proper interval.
> 
> So in new behaviour timer is stopped before advancing to next slide.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 1112767 
>   trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1112767 
> 
> Diff: http://reviewboard.kde.org/r/3529/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Reza
> 
>