Review Request: Added bouncing effect for Rotation animation

igorto igor_trindade at yahoo.com.br
Wed Apr 7 17:10:26 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3513/#review4908
-----------------------------------------------------------

Ship it!


Looks good. And i nice animation.

- igorto


On 2010-04-07 14:56:43, Bruno Abinader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3513/
> -----------------------------------------------------------
> 
> (Updated 2010-04-07 14:56:43)
> 
> 
> Review request for Plasma, igorto and Adenilson Cavalcanti.
> 
> 
> Summary
> -------
> 
> A new property "isBounceable" is added to the Rotation animation, which causes the target widget to "bounce" on a range between (-angle()/2, angle()/2). A static number of steps is defined by default (10 steps), causing the bounce angle to decrease through the animation steps. Notice that this effect doesn't behaves properly when the animation is part of a group, falling back to the "non-bounceable" behavior when it is part of a group.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/animations/rotation_p.h 1111462 
>   trunk/KDE/kdelibs/plasma/animations/rotation.cpp 1111462 
> 
> Diff: http://reviewboard.kde.org/r/3513/diff
> 
> 
> Testing
> -------
> 
> Tests have been made for different angles/axis on an additional example button on the animation plasmoid example. This example code is not yet release, but I can kindly pastebin it if needed.
> 
> 
> Thanks,
> 
> Bruno
> 
>



More information about the Plasma-devel mailing list