Review Request: Change the way dbus and fdo tasks are destroyed

Matthieu Gallien matthieu_gallien at yahoo.fr
Tue Apr 6 18:49:20 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3505/
-----------------------------------------------------------

Review request for Plasma, Aaron Seigo and Marco Martin.


Summary
-------

Try to make dbus and fdo tasks have the same life cycle. Now the Manager class is responsible for calling deleteLater. Make DBus tasks emits only once the destroyed signal.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/core/manager.cpp 1110082 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/core/task.cpp 1110082 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp 1110298 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/fdo/fdoselectionmanager.cpp 1110082 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/fdo/fdotask.h 1110082 

Diff: http://reviewboard.kde.org/r/3505/diff


Testing
-------

Tested with dbus and fdo tasks inside a kde 4.4.2 session and Qt 4.6.2. Nothing crash.


Thanks,

Matthieu



More information about the Plasma-devel mailing list