Review Request: Make the gridview behave correctly, no matter what icon size is set

[Shantanu Tushar Jha]

> On 2010-04-05 19:59:12, Alessandro Diaferia wrote:
> > I'm not 100% sure we should start with such an enormous size. I feel user preferences should be kept in high consideration, at least trying to find the biggest size among those specified by the user. In addition to this you can, and should IMHO, add the configuration option for this kind of setting inside the applet configuration interface.
> > 
> > I'd like to know others opinions before giving a "Ship It!" :-)

Oh, forgot to reply to this. Later we can add controls like zoom, or have a size calculated according to the user's screen size. To be able to do that, this patch fixes the grid view so that it can work with any size.


- Shantanu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3494/#review4883
-----------------------------------------------------------


On 2010-04-06 06:37:26, Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3494/
> -----------------------------------------------------------
> 
> (Updated 2010-04-06 06:37:26)
> 
> 
> Review request for Plasma, Marco Martin and Alessandro Diaferia.
> 
> 
> Summary
> -------
> 
> In the future, we need to support different sizes for previews. This patch adds preliminary support for this to happen. The size can be set in setIconSize in abstractmediaitemview.cpp . The desktop icon size was too small, made it 128 right now, will be changed soon.
> 
> 
> Diffs
> -----
> 
>   trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/abstractmediaitemview.cpp 1111046 
>   trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/viewitem.cpp 1111046 
> 
> Diff: http://reviewboard.kde.org/r/3494/diff
> 
> 
> Testing
> -------
> 
> Works fine with the only shortcoming that icon size can't be set at runtime, due to existing structure. This will be fixed soon, but should not block this patch from going in.
> 
> 
> Thanks,
> 
> Shantanu
> 
>