Review Request: Plasma::DialogManager

[Chani Armitage]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3474/#review4868
-----------------------------------------------------------

Ship it!



/trunk/KDE/kdelibs/plasma/applet.h
<http://reviewboard.kde.org/r/3474/#comment4354>

    hmmm.
    the screensaver could probably do with something like this... but... all it has are config dialogs and popupapplets (and popups look just fine except when they show up in the wrong position).
    
    I can't think of a non-config dialog that would need it, apart from kio's evil modal popups - can we actually catch those?
    
    most widgets are really quite good about doing everything on the scene. :)


- Chani


On 2010-04-03 19:09:42, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3474/
> -----------------------------------------------------------
> 
> (Updated 2010-04-03 19:09:42)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this is the DialogManager class, as discussed before on irc with aaron. will let plasma-netbook and plasma mobile show the config uis in a bit fancier way
> the base class happily does exactly nothing, actual implementations will be only in shells.
> there are still some doubts, expressed by the various todo/fixme :)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1110066 
>   /trunk/KDE/kdelibs/plasma/abstractdialogmanager.h PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/abstractdialogmanager.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/applet.h 1110066 
>   /trunk/KDE/kdelibs/plasma/applet.cpp 1110066 
>   /trunk/KDE/kdelibs/plasma/corona.h 1110066 
>   /trunk/KDE/kdelibs/plasma/corona.cpp 1110066 
> 
> Diff: http://reviewboard.kde.org/r/3474/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>