Review Request: Plasma::DialogManager

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3474/
-----------------------------------------------------------

(Updated 2010-04-03 19:09:42.668837)


Review request for Plasma.


Changes
-------

DialogManager is now AbstractDialogManager since the base does nothing and has a pure virtual
showDialog() has a parameter with the owning applet pointer too, useful if the config dialog will be into the scene

it is now committed, but i'm leaving it there because it really needs an api review :D


Summary
-------

this is the DialogManager class, as discussed before on irc with aaron. will let plasma-netbook and plasma mobile show the config uis in a bit fancier way
the base class happily does exactly nothing, actual implementations will be only in shells.
there are still some doubts, expressed by the various todo/fixme :)


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1110066 
  /trunk/KDE/kdelibs/plasma/abstractdialogmanager.h PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/abstractdialogmanager.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/applet.h 1110066 
  /trunk/KDE/kdelibs/plasma/applet.cpp 1110066 
  /trunk/KDE/kdelibs/plasma/corona.h 1110066 
  /trunk/KDE/kdelibs/plasma/corona.cpp 1110066 

Diff: http://reviewboard.kde.org/r/3474/diff


Testing
-------


Thanks,

Marco