Review Request: Plasma + Nepomuk - libplasma patch - attempt 1

[Ivan Cukic]

> On 2009-09-23 21:51:17, Chani wrote:
> > /trunk/KDE/kdelibs/plasma/containment.h, line 358
> > <http://reviewboard.kde.org/r/1699/diff/1/?file=11889#file11889line358>
> >
> >     s/activity/activityId to be extra clear. I don't like how "activity" sometimes means the name and sometimes the ID.

OK


> On 2009-09-23 21:51:17, Chani wrote:
> > /trunk/KDE/kdelibs/plasma/containment.h, line 363
> > <http://reviewboard.kde.org/r/1699/diff/1/?file=11889#file11889line363>
> >
> >     does this return the id or the name? and why's there no function to set just the name?

returns the ID

You can change the name of the activity... no, I haven't exposed that method in ContextManager (ex GlobalContext) but it will be.


> On 2009-09-23 21:51:17, Chani wrote:
> > /trunk/KDE/kdelibs/plasma/context.h, line 36
> > <http://reviewboard.kde.org/r/1699/diff/1/?file=11891#file11891line36>
> >
> >     add a comment saying this class is @since 4.4

OK


> On 2009-09-23 21:51:17, Chani wrote:
> > /trunk/KDE/kdelibs/plasma/context.h, line 67
> > <http://reviewboard.kde.org/r/1699/diff/1/?file=11891#file11891line67>
> >
> >     the function name could be better. maybe just activity. and what does it do if an activity with that id and a different name exists?

It creates another activity and returns the new ID.

The reasoning behind all of this is to have it more rugged when
- nepomuk is enabled/disabled between uses
- and to avoid breakage upon updating the system to new KDE


> On 2009-09-23 21:51:17, Chani wrote:
> > /trunk/KDE/kdelibs/plasma/context.h, line 93
> > <http://reviewboard.kde.org/r/1699/diff/1/?file=11891#file11891line93>
> >
> >     don't start function names with "for". either activityContext or contextForActivity

ok


> On 2009-09-23 21:51:17, Chani wrote:
> > /trunk/KDE/kdelibs/plasma/context.cpp, line 49
> > <http://reviewboard.kde.org/r/1699/diff/1/?file=11892#file11892line49>
> >
> >     so if nepomuk crashes and restarts itself, I have to restart plasma?
> >     
> >     plasma should watch for nepomuk appearing and disappearing.

Aaron said that we don't really care if the user is playing with on/off switch for nepomuk


> On 2009-09-23 21:51:17, Chani wrote:
> > /trunk/KDE/kdelibs/plasma/context.cpp, line 165
> > <http://reviewboard.kde.org/r/1699/diff/1/?file=11892#file11892line165>
> >
> >     you set realID to one thing, then another. skip this unnecessary assignment.

:)


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1699/#review2435
-----------------------------------------------------------


On 2009-09-23 20:19:36, Ivan Cukic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1699/
> -----------------------------------------------------------
> 
> (Updated 2009-09-23 20:19:36)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Nepomuk-based storage of plasma activities
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1027137 
>   /trunk/KDE/kdelibs/plasma/applet.cpp 1027137 
>   /trunk/KDE/kdelibs/plasma/containment.h 1027137 
>   /trunk/KDE/kdelibs/plasma/containment.cpp 1027137 
>   /trunk/KDE/kdelibs/plasma/context.h 1027137 
>   /trunk/KDE/kdelibs/plasma/context.cpp 1027137 
>   /trunk/KDE/kdelibs/plasma/private/activitieshandler.h PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/private/activitieshandler.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/private/context_p.h PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp 1027137 
>   /trunk/KDE/kdelibs/plasma/private/fallbackactivitieshandler.h PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/private/fallbackactivitieshandler.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/private/nepomukactivitieshandler.h PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/private/nepomukactivitieshandler.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1699/diff
> 
> 
> Testing
> -------
> 
> Needs more testing
> 
> 
> Thanks,
> 
> Ivan
> 
>