Review Request: Attempt to port KAlarm to KNotificationIcon

[Marco Martin]

> On 2009-09-22 05:12:41, David Jarvie wrote:
> > /trunk/KDE/kdepim/kalarm/kalarmapp.cpp, line 753
> > <http://reviewboard.kde.org/r/1655/diff/1/?file=11686#file11686line753>
> >
> >     This line shouldn't be removed unless there's some alternative mechanism for showing the window.
> 
>  wrote:
>     you can't show()/hide() it. you can only change the status from passive to active or needsattention.

yes, it should be just switched between passive/active


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1655/#review2414
-----------------------------------------------------------


On 2009-09-22 19:24:27, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1655/
> -----------------------------------------------------------
> 
> (Updated 2009-09-22 19:24:27)
> 
> 
> Review request for KDE PIM, Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> I've attempted to port KAlarm to KNotificationItem.
> I don't know how to port some pieces of code.
> Probably I will post a new patch soon.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kalarm/kalarmapp.h 1024122 
>   /trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1024122 
>   /trunk/KDE/kdepim/kalarm/mainwindow.cpp 1024122 
>   /trunk/KDE/kdepim/kalarm/traywindow.h 1024122 
>   /trunk/KDE/kdepim/kalarm/traywindow.cpp 1024122 
> 
> Diff: http://reviewboard.kde.org/r/1655/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>