Review request: Container plasma applet

[Aaron J. Seigo]

On September 20, 2009, Giulio Camuffo wrote:
> I've added in kdereview/plasma/applets an applet i made recently. It is, as
>  the name suggests, an applet that lets you contain and group other
>  applets.

this functionality belongs in a Containment, not an Applet.

we have two applets right now that can contain other applets: system tray and 
system monitor. the latter has had numerous bugs and is, to be frank, an 
implementation mistake. there is nothing that could not have been done much 
easier and with less hacking around stuff if system monitor had not been 
written to embed the various system monitor applets directly.

the design of Plasma is such that the Containment<->Applet relationship is 
quite carefully crafted and solves a lot of issues. ContainerWidget::drop 
which does not support various features found in Containment is a good example 
of this.

i think it's a nice candidate for publishing on kde-look.org and you can 
certainly put it into extragear if you'd like, but the concept is problematic 
from a design perspective and will cause inconsistencies and other problems if 
we ship it with Plasma.

given Containments have complete freedom on how to manage, group, etc. 
Applets, focusing these kinds of efforts there would make a lot more sense.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090920/c0474c23/attachment.sig