Review Request: fix a Plasma crash with a 16-bit screen depth and Qt 4.6

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1608/#review2360
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp
<http://reviewboard.kde.org/r/1608/#comment1655>

    this conversion should happen in explur so all users of it get this fix automatically.
    
    this also removes the need for the assert in expblur.
    
    otherwise, the patch looks good.


- Aaron


On 2009-09-14 15:00:05, Benjamin Stuhl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1608/
> -----------------------------------------------------------
> 
> (Updated 2009-09-14 15:00:05)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Meke sure that Plasma only tries to apply its software Gaussian blur to 32-bit QImages, since it will corrupt memory if applied to ones with lower bit depths. Add a Q_ASSERT to the effect to make testing easier.
> 
> 
> This addresses bug 207290.
>     https://bugs.kde.org/show_bug.cgi?id=207290
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp 1023128 
>   /trunk/KDE/kdelibs/plasma/private/effects/blur.cpp 1023128 
> 
> Diff: http://reviewboard.kde.org/r/1608/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin
> 
>