[PATCH] Fix annoying wallpaper list update behavior.

Alessandro Diaferia alediaferia at gmail.com
Mon Sep 14 14:54:38 CEST 2009


As from what happens with the current approach the view that lists available
wallpapers is connected to the modified() SLOT through the activated()
SIGNAL. But when the global preferences are set to use Double Click you have
to double click each item in the view in order to see the preview before
applying the wallpaper. This is a little annoying since there's apparently
no need for the view to "wait" for a double click before previewing the
wallpaper. In addition to this the behavior is not so intuitive.

This patch comes then:


Index: image/image.cpp
===================================================================
--- image/image.cpp     (revisione 1022077)
+++ image/image.cpp     (copia locale)
@@ -127,7 +127,7 @@ QWidget* Image::createConfigurationInter
                 fillMetaInfo(b);
             }
         }
-        connect(m_uiImage.m_view, SIGNAL(activated(const QModelIndex &)),
this, SLOT(pictureChanged(const QModelIndex &)));
+        connect(m_uiImage.m_view, SIGNAL(clicked(const QModelIndex &)),
this, SLOT(pictureChanged(const QModelIndex &)));

         m_uiImage.m_pictureUrlButton->setIcon(KIcon("document-open"));
         connect(m_uiImage.m_pictureUrlButton, SIGNAL(clicked()), this,
SLOT(showFileDialog()));

Is it ok for you to commit it?

-- 
Alessandro Diaferia
KDE Developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20090914/9863e284/attachment.htm 


More information about the Plasma-devel mailing list