Review Request: Use sunrise and sunset times from the Environment Canada weather service to set weather icon to day/night, accordingly.

[Beat Wolf]

> On 2009-05-03 16:42:23, Shawn Starr wrote:
> > It seems to be working so far, it's already committed.
> 
> Beat Wolf wrote:
>     i can't find this code in svn, is it really commited? can somebody mark this as submitted?
> 
> Shawn Starr wrote:
>     Its been redone. But we still dont have proper sunrise/sunset.

so can somebody please close this report? (since this patch is out of date)


- Beat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/665/#review1045
-----------------------------------------------------------


On 2009-05-03 16:05:40, Andrew Coles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/665/
> -----------------------------------------------------------
> 
> (Updated 2009-05-03 16:05:40)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Previously, day began at 6am, and night began at 6pm.  However, as summer approaches, this is increasingly far from the truth.  Hence, the real sunrise/sunset times are now used to determine whether it is day or night, and the weather icon set appropriately.  This also fixes issues with the weather wallpaper picking night-time images during the day.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_envcan.cpp 963098 
> 
> Diff: http://reviewboard.kde.org/r/665/diff
> 
> 
> Testing
> -------
> 
> I need someone who uses this weather service to test it for me.
> 
> 
> Thanks,
> 
> Andrew
> 
>